-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Fix observables query for network traffic with dst_port (#6070) #6073
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
+ Coverage 66.57% 66.72% +0.15%
==========================================
Files 540 540
Lines 64270 64184 -86
Branches 5223 5242 +19
==========================================
+ Hits 42788 42828 +40
+ Misses 21482 21356 -126 ☔ View full report in Codecov by Sentry. |
98b370e
to
42f9445
Compare
c3acba8
to
fa53c4e
Compare
return doc[key + '.keyword'].value; | ||
} | ||
} else if (doc[key].size()!=0) { | ||
return String.valueOf(doc[key].value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to return a String value because the type of the runtime field is "keyword". Otherwise we have a cast exception
aaab3e5
to
b7adf0f
Compare
Proposed changes
Related issues
Checklist