-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] disable field to edit default value in settings if needed (#6037) #6076
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6076 +/- ##
==========================================
+ Coverage 65.94% 66.13% +0.18%
==========================================
Files 541 541
Lines 64286 64287 +1
Branches 5199 5228 +29
==========================================
+ Hits 42393 42513 +120
+ Misses 21893 21774 -119 ☔ View full report in Codecov by Sentry. |
@@ -60,6 +61,7 @@ Omit<OpenVocabProps, 'type'> | |||
containerStyle, | |||
editContext, | |||
queryRef, | |||
disabled = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already initialized to false into DefaultValueField.tsx
, not necessary here. Or if it's really necessary here, isn't it also necessary in the other files (KillChainPhasesField, ObservableTypesField) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it's not necessary as in JS the boolean value of undefined is false. Still I think it's a good practice to initialize the value to a boolean as it is optional. Could be done in other components but nothing mandatory
cdc32a6
to
6368e31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally by playing with attributes definition. looks good. 👌
Proposed changes
Related issues
Checklist