Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix limit results to display correlation view (#5996) #6084

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 22, 2024

Proposed changes

  • Increase the limit to 500 (default: 20) for results sent by the backend, to display a graph consistent with overview / correlated reports

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

This will retrieve all the observables linked to the report, up to a limit of 500.
To get around the 500 limit, in the case of a report with more relationships, you would have to completely rethink the method for retrieving this data.

Test procedure

  • Use demo data (yarn insert:dev)
  • Create new report
  • In Knowledge, add 'send.have8000.com' indicator
  • Click on 'correlation view' => The graph display a relation between your NewReport and 'Poison Ivy' report
  • Go to 'Poison Ivy' report / overview / Correlated report => Expected : display line with your NewReport
  • Go to Knowledge / Correlation view
  • => [branch master] Nothing ! Expected : minimum the same relation
  • => [branch issue/5996] a beautiful graph with all relations

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 22, 2024
@frapuks frapuks self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.58%. Comparing base (7bd4156) to head (d523060).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6084      +/-   ##
==========================================
+ Coverage   66.57%   66.58%   +0.01%     
==========================================
  Files         540      540              
  Lines       64270    64270              
  Branches     5222     5224       +2     
==========================================
+ Hits        42786    42793       +7     
+ Misses      21484    21477       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@frapuks frapuks merged commit 1ae627a into master Feb 23, 2024
8 checks passed
@frapuks frapuks deleted the issue/5996 branch February 23, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants