-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix error message when attempting to create an artifact without file (#6052) #6090
Conversation
opencti-platform/opencti-graphql/src/domain/stixCyberObservable.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Laurent Bonnet <146674147+labo-flg@users.noreply.github.com>
Seen in pair review: it's more like a frontend display issue. The yup validation is working fine as it is in We need to pass down the formik errors to the This way user gets a good feedback in the form. As for the observable creation form, it's a lot more work as this is used for all types of observables, without yup validation... and backend errors are not always understandable. See #5454 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6090 +/- ##
==========================================
+ Coverage 65.71% 67.62% +1.91%
==========================================
Files 539 541 +2
Lines 63492 64661 +1169
Branches 5131 6094 +963
==========================================
+ Hits 41722 43726 +2004
+ Misses 21770 20935 -835 ☔ View full report in Codecov by Sentry. |
cdc32a6
to
6368e31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ✅
I just added a createArtifact test. I would appreciate a review of this part if possible. |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...