[backend] Fix upsert indicator score since decay (#2859) #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6100 +/- ##
==========================================
+ Coverage 66.73% 66.75% +0.01%
==========================================
Files 540 540
Lines 64180 64217 +37
Branches 5241 5241
==========================================
+ Hits 42832 42869 +37
Misses 21348 21348 ☔ View full report in Codecov by Sentry. |
SamuelHassine
force-pushed
the
master
branch
2 times, most recently
from
cdc32a6
to
6368e31
Compare
SouadHadjiat
force-pushed
the
issue/2859-fix-upsert-score
branch
from
0a37414
to
8b53c55
Compare
SouadHadjiat
commented
Feb 26, 2024
| @@ -2380,6 +2380,10 @@ const upsertElement = async (context, user, element, type, basePatch, opts = {}) | |||
| if (type === ENTITY_TYPE_INDICATOR) { | |||
| if (updatePatch.decay_applied_rule && updatePatch.decay_base_score === element.decay_base_score) { | |||
| logApp.debug('UPSERT INDICATOR -- no decay reset because no score change', { element, basePatch }); | |||
| updatePatch.x_opencti_score = element.x_opencti_score; // don't change the score | |||
| // don't reset valid_from & valid_until | |||
| updatePatch.valid_from = element.valid_from; | |||
There was a problem hiding this comment.
I'm not really sure about this part, I wonder if we might have a case where valid_from / valid_until change with the same score
SouadHadjiat
commented
Feb 26, 2024
| const labelledHistoryList: LabelledDecayHistory[] = []; | ||
| decayHistory.forEach((history) => ( | ||
| labelledHistoryList.push(getDisplayFor(history)) | ||
| const currentScoreIndex = decayHistory.findLastIndex((history) => history.score === indicator.x_opencti_score); |
There was a problem hiding this comment.
fix display of current score when we have multiple times in history the same score (it was displayed "Current stable score" each time)
SouadHadjiat
force-pushed
the
issue/2859-fix-upsert-score
branch
from
9dfe632
to
e61be3c
Compare
SouadHadjiat
force-pushed
the
issue/2859-fix-upsert-score
branch
from
e61be3c
to
0afa746
Compare
richard-julien
force-pushed
the
issue/2859-fix-upsert-score
branch
from
f5176b5
to
8e7e01f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist