Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] add more details to effective confidence level source #6114

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

labo-flg
Copy link
Member

The effective confidence level is computed by the backend according top the user's level, their groups levels and their capabilities.

The model did not allow to know that the confidence source was the bypass capability, we only had user or group.

This PR improves the API about effective confidence level and allow the frontend to display precise information on why the user has such effective value, including the bypass capa case.

@labo-flg labo-flg self-assigned this Feb 26, 2024
@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (18c4db8) to head (3b995bb).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6114   +/-   ##
=======================================
  Coverage   66.72%   66.73%           
=======================================
  Files         540      540           
  Lines       64180    64188    +8     
  Branches     5240     5240           
=======================================
+ Hits        42827    42835    +8     
  Misses      21353    21353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing generated file

@labo-flg labo-flg merged commit 5c43295 into master Feb 26, 2024
8 checks passed
@labo-flg labo-flg deleted the issue/fix-confidence-tooltip branch February 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants