[frontend] fix creator filter in user history redirection #6124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archidoit
added
filigran team
labo-flg
approved these changes
Feb 26, 2024
| @@ -65,6 +66,7 @@ const UserHistory: FunctionComponent<UserHistoryProps> = ({ | |||
| ], | |||
| operator: 'eq', | |||
| mode: 'or', | |||
| id: generateUUID(), // because filters in the URL | |||
There was a problem hiding this comment.
why do we need an id in filters ? and it's using a method from tests_e2e, I don't think its the right import.
There was a problem hiding this comment.
in filtersUtils.tsx, I see that you use :
id: uuid(),
I guess if we have now a logic with id in filters, we should use this same method uuid(), no?
jpkha
force-pushed
the
issue/user-history-redirection
branch
from
4ad21f2
to
46b3533
Compare
Archidoit
added a commit
that referenced
this pull request
Jun 6, 2024
Co-authored-by: Jean-Philippe Kha <jean-philippe.kha@filigran.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: get all relationships (or entities) created by a user, from the user view, seems to break the filters
Steps to reproduce:
Bug: this filter can't be edited