Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Fix fetch of containers in workspace #6155

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[frontend] Fix fetch of containers in workspace #6155

merged 1 commit into from
Feb 28, 2024

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Feb 28, 2024

Investigation -> Add in container -> No item

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Feb 28, 2024
SouadHadjiat
SouadHadjiat approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, fixes the issue ✅
I don't really understand however why filterKey is 'id'

@Kedae Kedae force-pushed the issue/fix-workspace-container branch from 81e104a to 306d1a4 Compare February 28, 2024 12:52
@Kedae Kedae merged commit 0e5bf01 into master Feb 28, 2024
6 checks passed
@Kedae Kedae deleted the issue/fix-workspace-container branch February 28, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat approved these changes

@JeremyCloarec JeremyCloarec JeremyCloarec approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kedae @SouadHadjiat @JeremyCloarec