Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix content mapping view #6159

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 28, 2024

Proposed changes

  • use the good answer in ternary if searchTerm is undefined

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@frapuks frapuks changed the title [frontend] manage undefined on ternary operator [frontend] fix content mapping view Feb 28, 2024
@frapuks frapuks self-assigned this Feb 28, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 28, 2024
@jpkha jpkha self-requested a review February 28, 2024 13:17
@frapuks frapuks marked this pull request as draft February 28, 2024 14:03
@frapuks frapuks marked this pull request as ready for review March 4, 2024 09:55
@frapuks frapuks force-pushed the issue/content-mapping-view branch from a35c4e4 to a25f68c Compare March 4, 2024 13:40
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (b483357) to head (5134692).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6159      +/-   ##
==========================================
- Coverage   66.64%   66.63%   -0.01%     
==========================================
  Files         541      541              
  Lines       64458    64458              
  Branches     5258     5257       -1     
==========================================
- Hits        42957    42952       -5     
- Misses      21501    21506       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks force-pushed the issue/content-mapping-view branch from a25f68c to 5134692 Compare March 7, 2024 15:52
@frapuks frapuks merged commit 3a07a52 into master Mar 7, 2024
8 checks passed
@frapuks frapuks deleted the issue/content-mapping-view branch March 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants