Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] fix search input disappears when going back to list #6161

Merged
merged 2 commits into from Feb 28, 2024
Merged

[frontend] fix search input disappears when going back to list #6161

merged 2 commits into from Feb 28, 2024

Conversation

jpkha
Copy link
Member

@jpkha jpkha commented Feb 28, 2024

Closed #6156

@jpkha jpkha changed the title [frontend] Fix - Search term was not keep between pages [frontend] search input disappears when going back to list Feb 28, 2024
@jpkha jpkha changed the title [frontend] search input disappears when going back to list [frontend] fix search input disappears when going back to list Feb 28, 2024
jpkha
jpkha commented Feb 28, 2024
View reviewed changes
opencti-platform/opencti-front/lang/front/en.json
@@ -402,7 +402,7 @@
"Campaigns": "Campaigns",
"Arsenal": "Arsenal",
"Variants": "Variants",
"Malwares": "Malwares",
"Malwares": "Malware",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See with @yassine-ouaamou, Malware did not take "s" in plural

@jpkha jpkha added the filigran team use to identify PR from the Filigran team label Feb 28, 2024
@yassine-ouaamou
Copy link
Member

All is good for me!

@jpkha jpkha merged commit 4dd66dc into master Feb 28, 2024
5 of 6 checks passed
@jpkha jpkha deleted the issue/6156 branch February 28, 2024 15:57
Kedae added a commit that referenced this pull request Mar 1, 2024
@Kedae
[frontend] Fix localStorage useless method (#6161)
3c61a93
Goumies pushed a commit that referenced this pull request Mar 13, 2024
@Kedae @Goumies
[frontend] Fix localStorage useless method (#6161)
3278821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassine-ouaamou yassine-ouaamou yassine-ouaamou approved these changes

@frapuks frapuks frapuks approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search input disappears when going back to list
3 participants
@jpkha @yassine-ouaamou @frapuks