Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Filter observables creation with refs from indicators (#5293) #6163

Merged
merged 3 commits into from Apr 3, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Feb 28, 2024

Proposed changes

  • filter observables created from indicators (API & playbook)
  • Adding unit tests

This solution to not create observables in this case has been seen with product team.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.69%. Comparing base (5993973) to head (99c1111).

Files Patch % Lines
...encti-platform/opencti-graphql/src/utils/syntax.js 80.00% 3 Missing ⚠️
...-graphql/src/modules/indicator/indicator-domain.ts 50.00% 1 Missing ⚠️
...raphql/src/modules/playbook/playbook-components.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6163   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         532      532           
  Lines       65010    65025   +15     
  Branches     5445     5449    +4     
=======================================
+ Hits        44009    44021   +12     
- Misses      21001    21004    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review April 2, 2024 15:14
@SamuelHassine SamuelHassine merged commit eb146f8 into master Apr 3, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5293 branch April 3, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants