Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add Playwright teams webhook #6178

Merged
merged 3 commits into from Mar 28, 2024

Conversation

jpkha
Copy link
Member

@jpkha jpkha commented Feb 29, 2024

Add a team webhook for Playwright.
In case of failure, we receive some screenshots so that we can debug more easily.

image
image

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (932c5d0) to head (ee5bae0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6178   +/-   ##
=======================================
  Coverage   66.74%   66.75%           
=======================================
  Files         541      541           
  Lines       64553    64553           
  Branches     5306     5307    +1     
=======================================
+ Hits        43088    43091    +3     
+ Misses      21465    21462    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpkha jpkha added the filigran team use to identify PR from the Filigran team label Feb 29, 2024
@jpkha jpkha force-pushed the issue/add-teams-webhook-playwright branch from 11d2308 to ee5bae0 Compare March 15, 2024 14:41
@labo-flg
Copy link
Member

Let's move on with this PR, we can try and see how it looks and if it's useful

@lndrtrbn
Copy link
Member

@jpkha could you merge it if it's good for you?

@jpkha jpkha merged commit c08cb0e into master Mar 28, 2024
8 checks passed
@jpkha jpkha deleted the issue/add-teams-webhook-playwright branch March 28, 2024 09:36
@jpkha
Copy link
Member Author

jpkha commented Mar 28, 2024

I merged it, but we still don't have any way to hide the team's URL, so it won't work yet, but it also won't crash anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants