Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] fix creator replaced by user in workbench (#6048) #6180

Merged
merged 1 commit into from Mar 1, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Feb 29, 2024

Proposed changes

  • frontend: add state in WorkbenchFileContent to to prevent useEffect from calling the saveFile() method each time content is loaded.
  • backend: replace creator_id by the cerator_id as it is stored in DB instead of user.id

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact marked this pull request as ready for review February 29, 2024 14:15
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 29, 2024
@SouadHadjiat SouadHadjiat linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (79bc968) to head (11ecedb).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6180   +/-   ##
=======================================
  Coverage   66.68%   66.69%           
=======================================
  Files         540      540           
  Lines       64349    64351    +2     
  Branches     5251     5253    +2     
=======================================
+ Hits        42909    42916    +7     
+ Misses      21440    21435    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-assigned this Feb 29, 2024
@marieflorescontact marieflorescontact changed the title [backend/frontend] fix creator changed when accessing an Analyst work… [backend/frontend] fix creator replaced by user in workbench Feb 29, 2024
@SouadHadjiat SouadHadjiat changed the title [backend/frontend] fix creator replaced by user in workbench [backend/frontend] fix creator replaced by user in workbench (#6048) Feb 29, 2024
@SamuelHassine SamuelHassine merged commit 583dfbd into master Mar 1, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6048 branch March 1, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creator changed when accessing an Analyst workbench
3 participants