Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix connectors work cleanup perf (#6031) #6203

Merged
merged 2 commits into from Mar 20, 2024
Merged

[backend] Fix connectors work cleanup perf (#6031) #6203

merged 2 commits into from Mar 20, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 1, 2024

Proposed changes

  • Retrieve only needed fields
  • Add sort by timestamp since there is no standard_id in Work objects.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Need help to test this change.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 1, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.74%. Comparing base (932c5d0) to head (252df52).

Files Patch % Lines
...rm/opencti-graphql/src/manager/connectorManager.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6203      +/-   ##
==========================================
- Coverage   66.74%   66.74%   -0.01%     
==========================================
  Files         541      541              
  Lines       64553    64559       +6     
  Branches     5306     5307       +1     
==========================================
+ Hits        43088    43090       +2     
- Misses      21465    21469       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review March 18, 2024 17:17
@Kedae Kedae merged commit e741337 into master Mar 20, 2024
8 checks passed
@Kedae Kedae deleted the issue/6031 branch March 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors related to Elasticsearch engine pagination.(CVE Connector error)
3 participants