Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent uppercase CSV + change 5MB labels to 1 MB as it should be #6243

Merged
merged 1 commit into from Mar 3, 2024

Conversation

yassine-ouaamou
Copy link
Member

@yassine-ouaamou yassine-ouaamou commented Mar 2, 2024

I didn't want to create an issue for such a simple thing. So I changed it.
If needed, I can create an issue and attach it.

Proposed changes

  • Consistent uppercase for the word "CSV"
  • Change the label of the max size of a file in a CSV mapper test. The limit is 1MB (5 would be too much). So I changed the label "5MB" to "1MB"

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (f0c79df) to head (eb8fd37).
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6243      +/-   ##
==========================================
+ Coverage   66.68%   66.90%   +0.21%     
==========================================
  Files         540      541       +1     
  Lines       64349    64413      +64     
  Branches     5251     5400     +149     
==========================================
+ Hits        42912    43096     +184     
+ Misses      21437    21317     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 0164860 into master Mar 3, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the csv_capital_letters branch March 3, 2024 07:17
Goumies pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants