Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve hub/children synchronization pattern (#6253) #6254

Merged
merged 1 commit into from Mar 3, 2024

Conversation

SamuelHassine
Copy link
Member

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 55.17241% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 66.66%. Comparing base (853ae73) to head (3661825).

Files Patch % Lines
...latform/opencti-graphql/src/database/middleware.js 71.42% 12 Missing ⚠️
...latform/opencti-graphql/src/manager/syncManager.js 0.00% 11 Missing ⚠️
...tform/opencti-graphql/src/database/file-storage.js 50.00% 1 Missing ⚠️
...i-platform/opencti-graphql/src/domain/connector.js 0.00% 1 Missing ⚠️
...ti-platform/opencti-graphql/src/graphql/graphql.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6254   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files         541      541           
  Lines       64408    64421   +13     
  Branches     5251     5256    +5     
=======================================
+ Hits        42936    42946   +10     
- Misses      21472    21475    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 8733303 into master Mar 3, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6253 branch March 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants