Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Do not submit on blur if the search value has not changed #6262

Merged
merged 2 commits into from Mar 4, 2024
Merged

[frontend] Do not submit on blur if the search value has not changed #6262

merged 2 commits into from Mar 4, 2024

Conversation

jpkha
Copy link
Member

@jpkha jpkha commented Mar 4, 2024

Closed #6260

@jpkha jpkha self-assigned this Mar 4, 2024
@jpkha jpkha requested a review from Archidoit March 4, 2024 09:24
@jpkha jpkha added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification and removed filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.67%. Comparing base (eb9f8cc) to head (2101650).

❗ Current head 2101650 differs from pull request most recent head 5844cc7. Consider uploading reports for the commit 5844cc7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6262   +/-   ##
=======================================
  Coverage   66.66%   66.67%           
=======================================
  Files         541      541           
  Lines       64426    64426           
  Branches     5257     5257           
=======================================
+ Hits        42948    42953    +5     
+ Misses      21478    21473    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpkha jpkha merged commit 238779c into master Mar 4, 2024
4 of 6 checks passed
Goumies pushed a commit that referenced this pull request Mar 13, 2024
@jpkha @Goumies
[frontend] Do not submit on blur if the search value has not changed (#…
7a08456 
…6262)
@SamuelHassine SamuelHassine deleted the issue/6260 branch April 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archidoit Archidoit Archidoit approved these changes

Assignees

@jpkha jpkha

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad behavior on top search bar
2 participants
@jpkha @Archidoit