Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Generate observables/indicators for all objects in bundle (#6266) #6271

Merged
merged 1 commit into from Mar 4, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 4, 2024

Proposed changes

  • return bundle after adding all objects to create (indicators or observables)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Looks like the issue has always been present, not a regression of the last release.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 4, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review March 4, 2024 15:59
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.65%. Comparing base (eb9f8cc) to head (1ce0231).

Files Patch % Lines
...raphql/src/modules/playbook/playbook-components.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6271      +/-   ##
==========================================
- Coverage   66.66%   66.65%   -0.01%     
==========================================
  Files         541      541              
  Lines       64426    64434       +8     
  Branches     5257     5256       -1     
==========================================
  Hits        42948    42948              
- Misses      21478    21486       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae merged commit 5db8587 into master Mar 4, 2024
8 checks passed
@Kedae Kedae deleted the issue/6266 branch March 4, 2024 18:03
@SamuelHassine SamuelHassine restored the issue/6266 branch March 4, 2024 18:51
@SamuelHassine SamuelHassine deleted the issue/6266 branch March 4, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playbook] "Promote observable to indicator" component doesn't work
2 participants