Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix cannot add TTP directly from matrix (#6112) #6272

Merged
merged 3 commits into from Mar 13, 2024

Conversation

SarahBocognano
Copy link
Member

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (2710f7b) to head (5a5c876).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6272   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files         541      541           
  Lines       64420    64420           
  Branches     5257     5257           
=======================================
  Hits        42957    42957           
  Misses      21463    21463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano self-assigned this Mar 7, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 7, 2024
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial issue is fix.
Just, is it normal that we can add multiple times the same relation between an Intrusion and a Technique? That's not directly related to the fix but now that the Add button works we face this scenario

@SarahBocognano It actually doesn't add multiple times the same relation, but yes maybe we can "disable" the add button if the relation already exist

@Kedae Kedae linked an issue Mar 12, 2024 that may be closed by this pull request
@SarahBocognano
Copy link
Member Author

Update: After a call with @nino-filigran , we will keep the "Add" button. Eveything is okay for product side, we can merge this issue like that

@SarahBocognano SarahBocognano merged commit 2345b8e into master Mar 13, 2024
8 checks passed
@SarahBocognano SarahBocognano deleted the issue/6112 branch March 13, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add TTP directly from matrix
3 participants