New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend]Verify createdBy type on malware creation (#6291) #6309
Conversation
opencti-platform/opencti-graphql/tests/02-integration/02-resolvers/malware-test.ts
Outdated
Show resolved
Hide resolved
@@ -144,7 +145,7 @@ import { | |||
isStixDomainObjectShareableContainer, | |||
isStixObjectAliased, | |||
resolveAliasesField, | |||
STIX_ORGANIZATIONS_UNRESTRICTED, | |||
STIX_ORGANIZATIONS_UNRESTRICTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this change ? the last ',' should be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ESLint that did it, I can revert that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand what's the convention for trailing commas in imports? There is already a mix of imports having a trailing comma on their last import line, and others not having it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
+ Coverage 66.71% 67.27% +0.56%
==========================================
Files 541 541
Lines 64501 64539 +38
Branches 5288 5594 +306
==========================================
+ Hits 43033 43420 +387
+ Misses 21468 21119 -349 ☔ View full report in Codecov by Sentry. |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...