Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] fix workflow filter with not_eq operator (#6307) #6330

Merged
merged 1 commit into from Mar 20, 2024
Merged

[backend] fix workflow filter with not_eq operator (#6307) #6330

merged 1 commit into from Mar 20, 2024

Conversation

Archidoit
Copy link
Member

issue: #6307

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Mar 13, 2024
@Archidoit Archidoit self-assigned this Mar 13, 2024
@Archidoit Archidoit marked this pull request as draft March 13, 2024 09:34
@Archidoit Archidoit marked this pull request as ready for review March 13, 2024 13:19
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 66.69%. Comparing base (6101d43) to head (753419d).
Report is 6 commits behind head on master.

Files Patch % Lines
...ti-platform/opencti-graphql/src/database/engine.js 0.00% 37 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6330      +/-   ##
==========================================
- Coverage   66.71%   66.69%   -0.02%     
==========================================
  Files         541      541              
  Lines       64491    64511      +20     
  Branches     5285     5286       +1     
==========================================
+ Hits        43025    43027       +2     
- Misses      21466    21484      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member Author

Missing some backend tests

JeremyCloarec
JeremyCloarec reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@JeremyCloarec JeremyCloarec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK, waiting on integration test to approve

@Archidoit Archidoit merged commit 7bf71e1 into master Mar 20, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6307 branch March 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyCloarec JeremyCloarec JeremyCloarec approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Archidoit @JeremyCloarec