Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix mass selection with the shift key in incidents container (#6283) #6331

Merged
merged 1 commit into from Mar 13, 2024

Conversation

CelineSebe
Copy link
Member

Proposed changes

  • add onToggleShiftEntity

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe self-assigned this Mar 13, 2024
@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Mar 13, 2024
@CelineSebe CelineSebe linked an issue Mar 13, 2024 that may be closed by this pull request
@CelineSebe CelineSebe marked this pull request as ready for review March 13, 2024 10:51
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (698b5a3) to head (a7ae3c9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6331      +/-   ##
==========================================
+ Coverage   66.71%   67.25%   +0.53%     
==========================================
  Files         541      541              
  Lines       64501    64501              
  Branches     5288     5569     +281     
==========================================
+ Hits        43033    43379     +346     
+ Misses      21468    21122     -346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@CelineSebe CelineSebe changed the title [frontend] Fix masse selection with the shift key in incidents container (#6283) [frontend] Fix mass selection with the shift key in incidents container (#6283) Mar 13, 2024
@CelineSebe CelineSebe merged commit e6f5899 into master Mar 13, 2024
8 checks passed
@CelineSebe CelineSebe deleted the issue/6283 branch March 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass selection with the shift key does not work on Incident
2 participants