Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add samples attribute to Malware in API #6337

Merged
merged 1 commit into from Mar 20, 2024
Merged

[backend] Add samples attribute to Malware in API #6337

merged 1 commit into from Mar 20, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Mar 13, 2024

Proposed changes

I added "samples" to the api model of malware, so that we can properly import sample refs when importing a malware stix bundle

See also the python client PR OpenCTI-Platform/client-python#584

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (932c5d0) to head (7448286).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6337   +/-   ##
=======================================
  Coverage   66.74%   66.75%           
=======================================
  Files         541      541           
  Lines       64553    64555    +2     
  Branches     5306     5307    +1     
=======================================
+ Hits        43088    43093    +5     
+ Misses      21465    21462    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec linked an issue Mar 14, 2024 that may be closed by this pull request
@JeremyCloarec JeremyCloarec marked this pull request as ready for review March 14, 2024 13:08
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 15, 2024
@SouadHadjiat SouadHadjiat self-requested a review March 15, 2024 14:30
@@ -5596,6 +5597,7 @@ input MalwareAddInput {
objectLabel: [String]
externalReferences: [String]
killChainPhases: [String]
samples: [String]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be changes in the generated file graphql.ts (when I started the backend I saw these changes locally)

@Kedae Kedae merged commit 6f75bda into master Mar 20, 2024
8 checks passed
@Kedae Kedae deleted the issue/6275 branch March 20, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample ref not created when importing a bundle STIX
4 participants