New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] avoid useless operations during batched replace (#6297) #6354
Conversation
15411bc
to
593fede
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
==========================================
+ Coverage 66.76% 66.97% +0.20%
==========================================
Files 541 541
Lines 64542 64557 +15
Branches 5306 5313 +7
==========================================
+ Hits 43091 43234 +143
+ Misses 21451 21323 -128 ☔ View full report in Codecov by Sentry. |
84a7fec
to
5dff342
Compare
4d4ad93
to
df40a78
Compare
const actionContext = { | ||
field: 'object-marking', | ||
type: 'RELATION', | ||
values: [MARKING_TLP_AMBER] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RCA on the counter issues: this id here is supposed to be an internal id and not a standard id. In the task manager the new check compares to an internal id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
765bdfd
to
1d3e041
Compare
1d3e041
to
0dda401
Compare
Proposed changes
REPLACE
relationship (with a marking, label, etc.) we check if thetoId
contained in value is not already in the element's relationships.Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...