Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix Files search EE button not aligned (#6346) #6376

Merged
merged 2 commits into from Mar 20, 2024
Merged

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Mar 18, 2024

Proposed changes

  • "display" css property added to fix icon alignment
  • Added tooltip with translation on search bar icons

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Mar 18, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title Issue/6346 Files search EE button not aligned #6346 Mar 18, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title Files search EE button not aligned #6346 Files search EE button not aligned (#6346) Mar 18, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title Files search EE button not aligned (#6346) [frontend] Files search EE button not aligned (#6346) Mar 18, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title [frontend] Files search EE button not aligned (#6346) [frontend] Fix Files search EE button not aligned (#6346) Mar 18, 2024
size="medium"
color={
<Tooltip title={t_i18n('Advanced search')}>
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless span

</span>
</Tooltip>
<Tooltip title={t_i18n('Bulk search')}>
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (932c5d0) to head (6a3cbe6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6376   +/-   ##
=======================================
  Coverage   66.74%   66.75%           
=======================================
  Files         541      541           
  Lines       64553    64553           
  Branches     5306     5306           
=======================================
+ Hits        43088    43091    +3     
+ Misses      21465    21462    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae merged commit 1d5c22f into master Mar 20, 2024
8 checks passed
@Kedae Kedae deleted the issue/6346 branch March 20, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants