Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve bulk Stix loader to support 100K+ relations loading in one bulk (#6386) #6387

Merged
merged 1 commit into from Mar 20, 2024

Conversation

richard-julien
Copy link
Member

See #6386

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Mar 19, 2024
@richard-julien richard-julien self-assigned this Mar 19, 2024
@richard-julien richard-julien removed the request for review from Archidoit March 19, 2024 13:03
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 66.76%. Comparing base (d857cc0) to head (f65d188).

Files Patch % Lines
...latform/opencti-graphql/src/database/middleware.js 68.96% 9 Missing ⚠️
...ti-platform/opencti-graphql/src/database/engine.js 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6387   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files         541      541           
  Lines       64542    64569   +27     
  Branches     5306     5311    +5     
=======================================
+ Hits        43091    43110   +19     
- Misses      21451    21459    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard self-assigned this Mar 20, 2024
@Kedae Kedae linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on report up to 501 relations, work fine. I also tested the for loop protection with MAX_EVENT_LOOP_PROCESSING_TIME it's working as expected too.

I haven't tested with 100k+ relations.

@Kedae Kedae merged commit a28aa57 into master Mar 20, 2024
8 checks passed
@Kedae Kedae deleted the issue/6386 branch March 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve bulk Stix loader to support 100K+ relations loading in one bulk
3 participants