Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix search broken in kill chain phases and marking definition (#6308 & #6318) #6394

Merged
merged 1 commit into from Mar 20, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Add missing attribute in search

In this PR I decided to join to issues as the problem was exactly the same for both

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@SarahBocognano SarahBocognano self-assigned this Mar 19, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 19, 2024
@SarahBocognano SarahBocognano changed the title [backend] Fix search broken in kill chain phases and marking definition (#6308) [backend] Fix search broken in kill chain phases and marking definition (#6308 & #6318) Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (70fb123) to head (e41f6f9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6394      +/-   ##
==========================================
- Coverage   66.97%   66.96%   -0.01%     
==========================================
  Files         541      541              
  Lines       64557    64561       +4     
  Branches     5313     5313              
==========================================
+ Hits        43234    43236       +2     
- Misses      21323    21325       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae merged commit 729df4c into master Mar 20, 2024
8 checks passed
@Kedae Kedae deleted the issue/6308 branch March 20, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants