Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] fromOrTo relations filters with different operators/modes combinations (#6390) #6395

Merged
merged 9 commits into from Mar 21, 2024

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Mar 20, 2024

PR content:

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Mar 20, 2024
@Archidoit Archidoit self-assigned this Mar 20, 2024
@Archidoit Archidoit linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.31%. Comparing base (1e90cee) to head (29fe85e).
Report is 1 commits behind head on master.

Files Patch % Lines
...ti-platform/opencti-graphql/src/database/engine.js 94.30% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6395      +/-   ##
==========================================
+ Coverage   67.26%   67.31%   +0.05%     
==========================================
  Files         541      541              
  Lines       65075    65192     +117     
  Branches     5397     5415      +18     
==========================================
+ Hits        43770    43882     +112     
- Misses      21305    21310       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec
Copy link
Contributor

Not equals doesn't seem to work properly with related entity type
image

@JeremyCloarec
Copy link
Contributor

Same thing for the "empty" operator, we still get results with it select:
image

@JeremyCloarec

This comment was marked as off-topic.

@Archidoit
Copy link
Member Author

The target entity list seem to contain more entities than the ones contained in the timeline image

it's normal, all the entities of the platform are present in the filter list values

@Archidoit Archidoit marked this pull request as draft March 20, 2024 17:31
@Archidoit Archidoit changed the title [backend/frontend] fix elementWithTargetTypes filter in Timeline (#6390) [backend/frontend] elementWithTargetTypes and fromOrToId filters with complex operators/modes combinations (#6390) Mar 21, 2024
@Archidoit
Copy link
Member Author

Not equals doesn't seem to work properly with related entity type image

fixed

@Archidoit Archidoit marked this pull request as ready for review March 21, 2024 14:37
@Archidoit
Copy link
Member Author

all the comments have been fixed :)

@Archidoit Archidoit changed the title [backend/frontend] elementWithTargetTypes and fromOrToId filters with complex operators/modes combinations (#6390) [backend/frontend] fromOrTo relations filters with different operators/modes combinations (#6390) Mar 21, 2024
@Archidoit Archidoit merged commit 0330878 into master Mar 21, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6390 branch March 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some filters in the entities' "knowledge" tabs don't seem to work.
2 participants