Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] use patchAttribute for ref relation Replace (#6295) #6396

Merged
merged 2 commits into from Mar 26, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Mar 20, 2024

Proposed changes

  • use patchAttribute instead of delete then create for ref relationship REPLACE

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact marked this pull request as ready for review March 25, 2024 15:31
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (12d021d) to head (e5006e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6396   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         532      532           
  Lines       64997    64972   -25     
  Branches     5434     5434           
=======================================
- Hits        43975    43960   -15     
+ Misses      21022    21012   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact marked this pull request as draft March 25, 2024 15:36
@marieflorescontact marieflorescontact marked this pull request as ready for review March 25, 2024 15:59
@marieflorescontact marieflorescontact merged commit b1ee60f into master Mar 26, 2024
8 checks passed
@marieflorescontact marieflorescontact deleted the issue/6295 branch March 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants