Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'in regards of' filter display in background tasks #6420

Merged
merged 3 commits into from Mar 29, 2024
Merged

'in regards of' filter display in background tasks #6420

merged 3 commits into from Mar 29, 2024

Conversation

Archidoit
Copy link
Member

issue: #6416

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Mar 22, 2024
@Archidoit Archidoit self-assigned this Mar 22, 2024
@Archidoit Archidoit linked an issue Mar 22, 2024 that may be closed by this pull request
'in regards of' filter not correctly displayed in background task #6416
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (b1ee60f) to head (7131470).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6420   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files         532      532           
  Lines       64976    64976           
  Branches     5433     5434    +1     
=======================================
  Hits        43964    43964           
  Misses      21012    21012

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marieflorescontact
marieflorescontact reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolbar no longer appears if select all is checked

image

@Archidoit
Copy link
Member Author

Toolbar no longer appears if select all is checked

image

@marieflorescontact This is not related to the original issue. Can you open another issue ?

@marieflorescontact
Copy link
Member

Toolbar no longer appears if select all is checked
image

@marieflorescontact This is not related to the original issue. Can you open another issue ?

Are you sure? I can't reproduce on testing:
image

@Archidoit
Copy link
Member Author

I can't reproduce the bug @marieflorescontact

marieflorescontact
marieflorescontact approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok 👌

@Archidoit Archidoit merged commit 1bf7973 into master Mar 29, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6416 branch March 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieflorescontact marieflorescontact marieflorescontact approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'in regards of' filter not correctly displayed in background task
2 participants
@Archidoit @marieflorescontact