New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] roll back investigation graph after expanding a node (#3167) #6468
Conversation
5c295a8
to
afe5ee2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6468 +/- ##
=======================================
Coverage 67.69% 67.70%
=======================================
Files 532 532
Lines 65144 65144
Branches 5470 5470
=======================================
+ Hits 44102 44104 +2
+ Misses 21042 21040 -2 ☔ View full report in Codecov by Sentry. |
...rc/private/components/workspaces/investigations/Dialog/InvestigationRollBackExpandDialog.tsx
Outdated
Show resolved
Hide resolved
...rc/private/components/workspaces/investigations/Dialog/InvestigationRollBackExpandDialog.tsx
Outdated
Show resolved
Hide resolved
...atform/opencti-front/src/private/components/workspaces/investigations/InvestigationGraph.jsx
Outdated
Show resolved
Hide resolved
...atform/opencti-front/src/private/components/workspaces/investigations/InvestigationGraph.jsx
Outdated
Show resolved
Hide resolved
...orm/opencti-front/src/private/components/workspaces/investigations/InvestigationGraphBar.jsx
Outdated
Show resolved
Hide resolved
...t/src/utils/sessionStorage/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
...-front/src/utils/sessionStorage/setStackDataInSessionStorage/setStackDataInSessionStorage.ts
Outdated
Show resolved
Hide resolved
...-front/src/utils/sessionStorage/setStackDataInSessionStorage/setStackDataInSessionStorage.ts
Outdated
Show resolved
Hide resolved
c274b3e
to
f9f6a39
Compare
f9f6a39
to
914ac83
Compare
...rc/private/components/workspaces/investigations/Dialog/InvestigationRollBackExpandDialog.tsx
Outdated
Show resolved
Hide resolved
740c7c7
to
8c77edf
Compare
...orm/opencti-front/src/private/components/workspaces/investigations/InvestigationGraphBar.jsx
Outdated
Show resolved
Hide resolved
I just tested locally :
|
Rollback shall put your graph into the state before the last expansion, so any entity added after the expand shall be lost. @ValentinBouzinFiligran Am I right ? |
d3a9891
to
85d4819
Compare
...atform/opencti-front/src/private/components/workspaces/investigations/InvestigationGraph.jsx
Show resolved
Hide resolved
The state after a restore doesn't always correspond to the state before the expansion Scénario 1: Scénario 2: |
b8d3a34
to
51c6e0b
Compare
…d from component (#3167)
51c6e0b
to
5e85846
Compare
...paces/investigations/utils/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
...paces/investigations/utils/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
...paces/investigations/utils/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
...paces/investigations/utils/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
...paces/investigations/utils/setStackDataInSessionStorage/setStackDataInSessionStorage.test.ts
Outdated
Show resolved
Hide resolved
756a4ed
to
c02f29b
Compare
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...