Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use good StixType for Infrastucture link (#6400) #6469

Merged
merged 1 commit into from Mar 26, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Mar 25, 2024

Proposed changes

  • fix Stix Object Type used in Infrastucture knowledge page (it impact the final link create to display relashionship)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks self-assigned this Mar 25, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (7b15b9c) to head (0d75a2a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6469      +/-   ##
==========================================
+ Coverage   67.62%   67.95%   +0.32%     
==========================================
  Files         531      532       +1     
  Lines       64916    65002      +86     
  Branches     5409     5929     +520     
==========================================
+ Hits        43898    44170     +272     
+ Misses      21018    20832     -186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit ead121a into master Mar 26, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6400 branch March 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to relationship object to ObservedData objects in Infrastructure object is wrong
3 participants