Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add widget PolarArea for relationships #6470

Merged
merged 1 commit into from Mar 27, 2024

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • Add the widget PolarArea as possible widget in dashboard for relationships

Related issues

  • Wish from Jermain

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (12d021d) to head (5cc726b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6470   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         532      532           
  Lines       64997    64997           
  Branches     5434     5435    +1     
=======================================
  Hits        43975    43975           
  Misses      21022    21022           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* @param {string[]} labels
* @param {function} formatter
* @param {string} legendPosition
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about that, can you explain to me what is the utility of it ? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows IDE like Intellij to be able to check the types of the parameters even if it is a JS file when you use this function in a TS file

@lndrtrbn lndrtrbn merged commit 275cd34 into master Mar 27, 2024
8 checks passed
@lndrtrbn lndrtrbn deleted the issue/widget-polar branch March 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants