Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Allow passwords with digits only for initial admin (#6382) #6489

Merged
merged 2 commits into from Mar 28, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Mar 26, 2024

Proposed changes

  • force value to be a String
  • add some test coverage on initial admin + coverage on the bug reproduction

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.71%. Comparing base (b1ee60f) to head (5251576).
Report is 2 commits behind head on master.

Files Patch % Lines
...pencti-platform/opencti-graphql/src/domain/user.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6489      +/-   ##
==========================================
+ Coverage   67.66%   67.71%   +0.05%     
==========================================
  Files         532      532              
  Lines       64976    64989      +13     
  Branches     5433     5444      +11     
==========================================
+ Hits        43964    44010      +46     
+ Misses      21012    20979      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review March 27, 2024 14:06
@aHenryJard aHenryJard changed the title Allow passwords with digits only for initial admin (#6382) [backend] Allow passwords with digits only for initial admin (#6382) Mar 27, 2024
@SamuelHassine SamuelHassine merged commit 5e7492d into master Mar 28, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6382-passwords branch April 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial admin password with digits only fails on first platform start
3 participants