Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] hide create widget button for read-only dashboard (#6464) #6511

Merged
merged 1 commit into from Mar 29, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Mar 28, 2024

Proposed changes

  • check if current user has edit right for current dashboard

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact self-assigned this Mar 28, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review March 28, 2024 14:37
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (c08cb0e) to head (438aba6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6511   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files         532      532           
  Lines       64989    64989           
  Branches     5444     5444           
=======================================
  Hits        43998    43998           
  Misses      20991    20991           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit a476caa into master Mar 29, 2024
8 checks passed
@marieflorescontact marieflorescontact deleted the issue/6464 branch March 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants