Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Uncheck the 'select all' box when launching a background task (#6526) #6532

Merged
merged 3 commits into from Apr 3, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Apr 2, 2024

Proposed changes

  • In Notifications: Add selectedAll

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe added the bug use for describing something not working as expected label Apr 2, 2024
@CelineSebe CelineSebe self-assigned this Apr 2, 2024
@CelineSebe CelineSebe linked an issue Apr 2, 2024 that may be closed by this pull request
@CelineSebe CelineSebe added filigran team use to identify PR from the Filigran team and removed bug use for describing something not working as expected labels Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (5993973) to head (ded8dd3).
Report is 14 commits behind head on master.

❗ Current head ded8dd3 differs from pull request most recent head 5072fbe. Consider uploading reports for the commit 5072fbe to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6532   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         532      532           
  Lines       65010    65010           
  Branches     5445     5446    +1     
=======================================
+ Hits        44009    44010    +1     
+ Misses      21001    21000    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -193,6 +193,7 @@ const NotificationsToolBar: FunctionComponent<NotificationsToolBarProps> = ({
},
},
onCompleted: () => {
handleClearSelectedElements();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to add this call here since it's already called in onSubmitCompleted() (l162) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's fixed. Thanks.

@SamuelHassine SamuelHassine merged commit e0f10fe into master Apr 3, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/6526 branch April 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching a background task should uncheck the select all box
3 participants