Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve connection drop handling for importCSV connector (#6314) #6533

Merged
merged 2 commits into from Apr 3, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Apr 2, 2024

Proposed changes

Some of the connection errors on rabbitMQ are sent to the 'close' event and not in the 'error' event. We added an handler for the 'close' event to be able to reconnect to rabbitMQ when possible

Related issues

#6314

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@JeremyCloarec JeremyCloarec added the filigran team use to identify PR from the Filigran team label Apr 2, 2024
@JeremyCloarec JeremyCloarec added this to the Release 6.0.9 milestone Apr 2, 2024
@Archidoit Archidoit linked an issue Apr 2, 2024 that may be closed by this pull request
@Archidoit Archidoit changed the title [backend] Improve connection drop handling for importCSV connector [backend] Improve connection drop handling for importCSV connector (#6314) Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.68%. Comparing base (7b0bcf3) to head (cc213e9).

Files Patch % Lines
...hql/src/connector/importCsv/importCsv-connector.ts 0.00% 8 Missing ⚠️
...-platform/opencti-graphql/src/database/rabbitmq.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6533      +/-   ##
==========================================
- Coverage   67.69%   67.68%   -0.01%     
==========================================
  Files         532      532              
  Lines       65010    65022      +12     
  Branches     5445     5445              
==========================================
+ Hits        44008    44010       +2     
- Misses      21002    21012      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit c8481a2 into master Apr 3, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6314 branch April 3, 2024 05:59
@SamuelHassine SamuelHassine removed this from the Release 6.0.9 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV Import Connector getting hung up on imports
3 participants