Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix "Select all" not available for relationship creation (#6407) #6574

Merged
merged 1 commit into from Apr 5, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • As said in the issue the disabled "select all" was there on purpose. To avoid the pain of entities by entities selection, we just add the possiblity to MAJ+select to perform bulk selection for both StixCoreRelationships & StixNestedRef. By selecting the correct filters, users will still be able to perform a mutli select more quickly and painlessly.

Related issues

@SarahBocognano SarahBocognano self-assigned this Apr 4, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Apr 4, 2024
@SarahBocognano SarahBocognano changed the title [frontend] Fix "Select all" not available for relationship creation (#issue/6407) [frontend] Fix "Select all" not available for relationship creation (#6407) Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (ed2e24d) to head (e351acb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6574   +/-   ##
=======================================
  Coverage   67.77%   67.78%           
=======================================
  Files         532      532           
  Lines       65102    65102           
  Branches     5469     5470    +1     
=======================================
+ Hits        44124    44127    +3     
+ Misses      20978    20975    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@SarahBocognano SarahBocognano merged commit cb6fb6b into master Apr 5, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6407 branch April 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants