[frontend] CI Verify translation automatically #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6590 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.01%
==========================================
Files 532 532
Lines 65144 65144
Branches 5470 5470
==========================================
- Hits 44104 44102 -2
- Misses 21040 21042 +2 ☔ View full report in Codecov by Sentry. |
|
Do you think it would be possible to sort the translation files during keys generation and automatic translation ? so that the keys are added by alphabetical order, and not at the end of the file. This would avoid all our conflicts where all the keys are added automatically at the end of files. And also sorting will help organize the keys. |
jpkha
force-pushed
the
issue/add-verification-step-drone
branch
from
ebadd70
to
172be2d
Compare
|
In case there is missing translation : |
SouadHadjiat
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a verification step for translation in Drone