Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the redirection to "files" when exporting in observed data and notes #6628

Merged
merged 3 commits into from Apr 11, 2024

Conversation

CelineSebe
Copy link
Member

Proposed changes

  • Add the 'redirectToContent' props to the roots of notes and observed data

Reproducible Steps

In Events/observed data and Events/Notes:

  1. Click on the quick button export, at the top right
  2. Verify that the page displays correctly with 'files?' in the URL and not 'content?'

Actual Output

button export with content in path

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe force-pushed the issue/fix-redirectionToContent branch from bcabc56 to 57dd4d9 Compare April 9, 2024 07:46
@CelineSebe CelineSebe changed the title Fix the redirection to content when exporting in observed data and notes Fix the redirection to "files" when exporting in observed data and notes Apr 9, 2024
@CelineSebe CelineSebe marked this pull request as ready for review April 9, 2024 07:48
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@9ccc098). Click here to learn what that means.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6628   +/-   ##
=========================================
  Coverage          ?   67.70%           
=========================================
  Files             ?      532           
  Lines             ?    65144           
  Branches          ?     5471           
=========================================
  Hits              ?    44104           
  Misses            ?    21040           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe self-assigned this Apr 9, 2024
@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Apr 9, 2024
Copy link
Member

@frapuks frapuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test ok

@CelineSebe CelineSebe merged commit f83fb87 into master Apr 11, 2024
5 checks passed
@CelineSebe CelineSebe deleted the issue/fix-redirectionToContent branch April 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants