Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] relationship page - remove padding right #6631

Merged
merged 1 commit into from Apr 9, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Apr 9, 2024

Proposed changes

  • Remove padding right when dont have right bar

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • Before : update button -> padding right without right bar
    image

  • Now : No padding
    image

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Apr 9, 2024
@frapuks frapuks self-assigned this Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@9ccc098). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6631   +/-   ##
=========================================
  Coverage          ?   67.69%           
=========================================
  Files             ?      532           
  Lines             ?    65144           
  Branches          ?     5472           
=========================================
  Hits              ?    44101           
  Misses            ?    21043           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks merged commit 3e060b3 into master Apr 9, 2024
5 checks passed
@frapuks frapuks deleted the issue/router-oberservable-relationship branch April 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants