Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix rels batch loading (#6635) #6636

Merged
merged 2 commits into from Apr 10, 2024
Merged

[backend] fix rels batch loading (#6635) #6636

merged 2 commits into from Apr 10, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Apr 9, 2024

Proposed changes

  • create batch loader outside of loadThroughDenormalized, otherwise there was no batch loading, we were loading rels for each element one by one.
  • remove unused graphql queries : countries on IPs and reports on stix core objects (they were not used and were time consuming)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Apr 9, 2024
@SouadHadjiat SouadHadjiat linked an issue Apr 9, 2024 that may be closed by this pull request
@SouadHadjiat SouadHadjiat marked this pull request as ready for review April 9, 2024 15:52
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (d9694b1) to head (426d5e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6636   +/-   ##
=======================================
  Coverage   67.69%   67.70%           
=======================================
  Files         532      532           
  Lines       65144    65144           
  Branches     5470     5473    +3     
=======================================
+ Hits        44101    44104    +3     
+ Misses      21043    21040    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat merged commit 9bb7b22 into master Apr 10, 2024
5 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6635 branch April 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow list entities graphQL queries with refs loading
2 participants