Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] replace icon anchor on minimap (#6599) #6639

Merged
merged 1 commit into from Apr 10, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Apr 10, 2024

Proposed changes

  • Replace icon anchor on minimap

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • I use 12 because it's approximatly 25 (icon size) / 2, to replace anchor on icon center
  • I replace too popup anchor, even if not used

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Apr 10, 2024
@frapuks frapuks self-assigned this Apr 10, 2024
@frapuks frapuks linked an issue Apr 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (d9694b1) to head (b5fdb21).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6639   +/-   ##
=======================================
  Coverage   67.69%   67.70%           
=======================================
  Files         532      532           
  Lines       65144    65144           
  Branches     5470     5470           
=======================================
+ Hits        44101    44104    +3     
+ Misses      21043    21040    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks merged commit 8791d29 into master Apr 10, 2024
7 checks passed
@frapuks frapuks deleted the issue/6599 branch April 10, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers on map are not placed at the right place
2 participants