Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Added feature flag for Floating Action Button replacement #6738

Merged

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added "FAB_REPLACEMENT" to default.json to ignore the ongoing FAB replacement tasking in non-development environments.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I am working to decompose #5269 into smaller PRs. This feature flag enables non-development environments to not be affected by efforts to replace the floating action button throughout the platform in the meantime.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (e7b4870) to head (cd44830).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6738   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files         538      538           
  Lines       65711    65711           
  Branches     5568     5568           
=======================================
  Hits        44691    44691           
  Misses      21020    21020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn merged commit b1e2cd6 into OpenCTI-Platform:master Apr 22, 2024
4 checks passed
@Bonsai8863 Bonsai8863 deleted the feature/fab_replacement/core branch April 22, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants