Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Complete Reports e2e tests (#5648) #6927

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented May 10, 2024

Proposed changes

  • Add a test case to add entities in a Report

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label May 10, 2024
@lndrtrbn lndrtrbn changed the title (frontend) test cases for CRUD Reports: entities and observables tabs (#5648) [frontend] Complete Reports e2e tests (#5648) May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (0ca75db) to head (90f150d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6927   +/-   ##
=======================================
  Coverage   67.41%   67.41%           
=======================================
  Files         561      561           
  Lines       68541    68541           
  Branches     5713     5715    +2     
=======================================
+ Hits        46205    46210    +5     
+ Misses      22336    22331    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn marked this pull request as ready for review May 15, 2024 08:50
@marieflorescontact marieflorescontact merged commit b1dc76d into master May 15, 2024
5 checks passed
@marieflorescontact marieflorescontact deleted the issue/5648-2 branch May 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants