Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond-centric manipulate should allow inter-ring bonds to adjust #1000

Closed
ghutchis opened this issue Jul 6, 2022 · 3 comments · Fixed by #1006
Closed

Bond-centric manipulate should allow inter-ring bonds to adjust #1000

ghutchis opened this issue Jul 6, 2022 · 3 comments · Fixed by #1006

Comments

@ghutchis
Copy link
Member

ghutchis commented Jul 6, 2022

When using the bond-centric manipulate tool, bonds between two rings should be adjustable.

At the moment, if you try to adjust the bond between rings in biphenyl, just one atom moves:
Screen Shot 2022-07-05 at 9 16 51 PM
@avo-bot
Copy link

avo-bot commented Jul 6, 2022

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/more-intuitive-behaviour-for-bond-centric-manipulation-tool/3893/4

ghutchis added a commit to ghutchis/avogadrolibs that referenced this issue Jul 7, 2022
@ghutchis
When finding connected atoms, only ignore rings containing the bond
f057731 
Fixes OpenChemistry#1000

(Not entirely.. this seems to ignore some hydrogen atoms?)

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis mentioned this issue Jul 7, 2022
Merged
ghutchis added a commit to ghutchis/avogadrolibs that referenced this issue Jul 7, 2022
@ghutchis
When finding connected atoms, only ignore rings containing the bond
97a4da8 
Fixes OpenChemistry#1000

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When finding connected atoms, only ignore rings containing the bond ghutchis/avogadrolibs
2 participants
@ghutchis @avo-bot