We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avogadro version: (please complete the following information from the About box):
Desktop version: (please complete the following information):
Describe the bug Here https://github.com/OpenChemistry/avogadrolibs/blob/master/avogadro/qtplugins/insertfragment/CMakeLists.txt#L48 crystals are only installed when downloaded with git, and not when this directory is supplied by the caller. This is different from the molecules directory that is (correctly) installed when it is supplied by the caller.
molecules
The text was updated successfully, but these errors were encountered:
Thanks - it's the endif() in the wrong spot. I'll go fix that - sorry!
Sorry, something went wrong.
When I saw the issue posted, I thought 'that's weird, it's parallel code" - but no, it's not. Thanks for the issue.
Make sure to install crystals directory even when it exists
2b0a444
Fixes OpenChemistry#611 - thanks to @yurivict Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Here are the build results macOS.dmg Ubuntu-2004.tar.gz Win64.exe Artifacts will only be retained for 90 days.
Successfully merging a pull request may close this issue.
Avogadro version: (please complete the following information from the About box):
Desktop version: (please complete the following information):
Describe the bug
Here https://github.com/OpenChemistry/avogadrolibs/blob/master/avogadro/qtplugins/insertfragment/CMakeLists.txt#L48 crystals are only installed when downloaded with git, and not when this directory is supplied by the caller. This is different from the
molecules
directory that is (correctly) installed when it is supplied by the caller.The text was updated successfully, but these errors were encountered: