Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't install the 'crystals' directory when it is supplied by the caller #611

Closed
yurivict opened this issue Jun 4, 2021 · 3 comments · Fixed by #613
Closed

Doesn't install the 'crystals' directory when it is supplied by the caller #611

yurivict opened this issue Jun 4, 2021 · 3 comments · Fixed by #613

Comments

@yurivict
Copy link
Contributor

yurivict commented Jun 4, 2021

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.94.0

Desktop version: (please complete the following information):

  • OS: FreeBSD 13

Describe the bug
Here https://github.com/OpenChemistry/avogadrolibs/blob/master/avogadro/qtplugins/insertfragment/CMakeLists.txt#L48 crystals are only installed when downloaded with git, and not when this directory is supplied by the caller. This is different from the molecules directory that is (correctly) installed when it is supplied by the caller.

@ghutchis
Copy link
Member

ghutchis commented Jun 7, 2021

Thanks - it's the endif() in the wrong spot. I'll go fix that - sorry!

@ghutchis
Copy link
Member

ghutchis commented Jun 7, 2021

When I saw the issue posted, I thought 'that's weird, it's parallel code" - but no, it's not. Thanks for the issue.

ghutchis added a commit to ghutchis/avogadrolibs that referenced this issue Jun 7, 2021
Fixes OpenChemistry#611 - thanks to @yurivict

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

Here are the build results
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants