Unselected atoms become selected (and vice versa) when other atoms are deleted #650
Comments
|
This issue has been mentioned on Avogadro Discussion. There might be relevant details there: |
ghutchis
added a commit
to ghutchis/avogadrolibs
that referenced
this issue
Jul 14, 2021
Two bugs in one - selected items weren't updated by Molecule class and atoms were removed in a bad order. (Remove in reverse to keep Index correct) Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
|
Here are the build results |
|
@drew-parsons @mquevill - as far as I can tell, the patch fixes the problem... |
|
The patch looks like it's making the right corrections. The codebase has diverged from 1.94.0 now so I can't apply and test so easily as a single patch. |
ghutchis
added a commit
to ghutchis/avogadrolibs
that referenced
this issue
Jul 16, 2021
Bug raised by @mquevill - delete a non-selected atom Since deleting atoms renumbers, make sure selected atoms stays with "swap and pop" form from atom index, etc. Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
|
Here are the build results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
**Avogadro version: 1.94.0-371-g7479d2e **
**Desktop version: **
Describe the bug
When some atoms in a molecule are selected, and other atoms are then deleted, some of the selected atoms become deselected.
Conversely if some selected atoms are deleted, then some previously deselected atoms suddenly become selected.
My guess is that the list of selected atoms is a list of indices to the atoms in the molecule, and is not refreshed when the lists of atoms in the molecule changes (e,g, by deletion).
To Reproduce
Steps to reproduce the behavior:
Create a simple ethane molecule
Click on Selection Tool and select the right-most methyl
Select Build [pencil] tool
Delete (right-click) one of the unselected hydrogens on the left. That hydrogen disappears, but one of the hydrogens on the right becomes deselected.
Conversely,
2'. Click on Selection Tool and select the left-most methyl
4'. Delete (right-click) one of the selected hydrogens on the left. That hydrogen disappears, but one of the hydrogens on the right becomes selected.
Expected behavior
Previously deselected atoms should not suddenly become selected when atoms are removed (or added).
Previously selected atoms should not suddenly become deselected when atoms are removed (or added) (or alternatively the entire selection should get cleared).
The text was updated successfully, but these errors were encountered: