Support for color PLY format #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spotenza2016 <saganpotenza@gmail.com> Signed-off-by: spotenza2016 <64374401+spotenza2016@users.noreply.github.com>
Signed-off-by: spotenza2016 <saganpotenza@gmail.com> Signed-off-by: spotenza2016 <64374401+spotenza2016@users.noreply.github.com>
spotenza2016
force-pushed
the
master
branch
from
39d326b
to
e16b571
Compare
Signed-off-by: spotenza2016 <64374401+spotenza2016@users.noreply.github.com>
Signed-off-by: spotenza2016 <64374401+spotenza2016@users.noreply.github.com>
Signed-off-by: spotenza2016 <64374401+spotenza2016@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| qobject_cast<QWidget*>(parent()), tr("Save File"), QDir::homePath(), | ||
| tr("PLY (*.ply);;Text file (*.txt)")); | ||
| QFile file(filename); | ||
| if (!file.open(QIODevice::WriteOnly)) |
Check notice
Code scanning / Flawfinder (reported by Codacy)
Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).
|
Here are the build results |
|
Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone! |
|
Here are the build results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of issue (#412)
I have added PLY export Functionality and tested to verify it works. I have also added places where different methods for generating spheres/cylinders could be added.
The only thing of note is I believe the mesh for the coordinate system symbol has misordered vertices, resulting in mismatched normals and causing some PLY Reading Programs to complain, but I have confirmed this is limited only to the visit mesh function that visits that coordinate system mesh.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.