Allow for reading imaginary vibrational frequencies in ORCA outputs. #1398
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
dtelsing
force-pushed
the
orca_imaginary_freq
branch
from
f7a0062
to
22e88ce
Compare
|
Great, thanks! I obviously haven't dealt with many TS or imaginary modes and was largely porting the "Orca-enhanced Avogadro 1.2" code. |
|
The CMake build failure on Ubuntu / GCC seems like a problem on that build node. I'll restart in an hour or two. (There are lots of new PR, so each is taking a while.) |
|
Here are the build results |
|
If you can make the minor changes I mentioned, I'm happy to merge this ASAP. Thanks! |
dtelsing
force-pushed
the
orca_imaginary_freq
branch
from
22e88ce
to
903c5c5
Compare
They are marked by ***imaginary mode*** after the frequency. Also, abort reading normal modes, the IR or the Raman spectrum if an invalid index was found. Signed-off-by: David Elsing <david.elsing@posteo.net>
dtelsing
force-pushed
the
orca_imaginary_freq
branch
from
903c5c5
to
603d465
Compare
|
Here are the build results |
|
Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone! |
|
Here are the build results |
When reading an ORCA output file with an imaginary mode (which have an imaginary mode comment in the frequency line), the line and subsequent lines are skipped. This leads to an out-of-bounds access when reading normal modes, the IR spectrum or the Raman spectrum, as the indices read from the file are not verified.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.